Fix wrong option name in en/blog/release/v12.12.0.md#2676
Merged
Trott merged 1 commit intonodejs:masterfrom Oct 14, 2019
Merged
Fix wrong option name in en/blog/release/v12.12.0.md#2676Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
nschonni
approved these changes
Oct 14, 2019
Member
nschonni
left a comment
There was a problem hiding this comment.
Thanks, looks like the naming changed between the initial PR and description and the final commit
Trott
approved these changes
Oct 14, 2019
Member
|
Refs: nodejs/node#29959 I suspect they'll both be 👍 on it, but /ping @bcoe @BridgeAR anyway |
Member
|
Actually, this is kind of important (as people are reading this blog post now but not so much in a week) so I'm going to land this right away. We can always change it again if need be. |
Member
|
Thank a lot for the fix. |
|
@Trott thanks for catching this and fixing it. |
|
likewise @mysticatea, thank you both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the option name in the blog post is wrong.