Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
I wonder if this change contradicts with the reason why this change got added to begin with, but I'm fine with this chamge. |
ovflowd
approved these changes
Apr 18, 2024
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
mikeesto
approved these changes
Apr 19, 2024
Member
mikeesto
left a comment
mikeesto
left a comment
There was a problem hiding this comment.
Looks better on my monitor so +1 from me
Contributor
|
But this causes ugly layout shift again. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
scrollbar-gutterproperty was set tostable, causing the scrollbar placeholder to always be present, even when scrollbars were not visible. This resulted in unwanted empty space affecting the website's design. I changed it from 'stable' to 'auto' to resolve the scrollbar display issue.Validation
when scrollbar is visible:
when scrollbar is not visible:
After the change:
Related Issues
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.