chore: remove reference to outdated examples#6851
Merged
mikeesto merged 1 commit intonodejs:mainfrom Jul 6, 2024
avivkeller:patch-1
Merged
chore: remove reference to outdated examples#6851mikeesto merged 1 commit intonodejs:mainfrom avivkeller:patch-1
mikeesto merged 1 commit intonodejs:mainfrom
avivkeller:patch-1
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bmuenzenmeyer
requested changes
Jun 20, 2024
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
blocking until nodejs/admin#883 is resolved
Member
Author
Thanks! I wanted this blocked until that's resolved anyway, but I wanted to put it in the works to make sure it's okay dev-wise |
bmuenzenmeyer
approved these changes
Jun 22, 2024
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
this is now unblocked due to the resolution of the other issue - but we wont merge until we solidify monorepo work
Contributor
|
This PR will need to be rebased or recreated now that #6850 merged. |
Member
Author
|
Done! |
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage ReportUnit Test Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the reference to the outdated example repository, as in its current state, it may confuse users more than help them.
Related Issues
nodejs/admin#883 discusses archiving the repository, and this is the only actively maintained link to the repository.
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.