Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds versioned release badges to the home page and enables sizing for badge components.
- Introduces a
sizeprop toBadgeandBadgeGroupwith default"medium" - Updates CSS for badge message links to maintain consistent styling
- Integrates
BadgeGroupinto MDX components and home page, and configures Turbo UI
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| turbo.json | Enable Turbo UI by setting "ui": "tui" |
| packages/ui-components/src/Common/BadgeGroup/index.tsx | Added size prop support and type reuse |
| packages/ui-components/src/Common/BadgeGroup/index.stories.tsx | Added SmallDefault story for badge sizes |
| packages/ui-components/src/Common/BadgeGroup/index.module.css | Extended .message selector for link styling |
| packages/ui-components/src/Common/Badge/index.tsx | Introduced BadgeSize alias for size strings |
| apps/site/pages/en/index.mdx | Render version badges on the home page |
| apps/site/next.mdx.use.mjs | Imported and exposed BadgeGroup to MDX |
Comments suppressed due to low confidence (1)
packages/ui-components/src/Common/BadgeGroup/index.stories.tsx:17
- [nitpick] We have a
SmallDefaultstory for the default badge size, but no story demonstrating thewarningorerrorvariants at thesmallsize. Adding those would ensure visual regression coverage for all size/variant combinations.
export const SmallDefault: Story = {
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7962 +/- ##
==========================================
+ Coverage 73.72% 73.74% +0.02%
==========================================
Files 96 96
Lines 8365 8365
Branches 219 219
==========================================
+ Hits 6167 6169 +2
+ Misses 2197 2195 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
It's also not clear where these link to someone visiting the homepage |
That is true. I'm wondering if we should even have links there 🤷 |
|
👀 I would probably expect the entire pill to be a link, not just the text? |
You're right. |
Done |
|
cc @dario-piotrowicz playwright is failing for unknown reasons to me. |
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org>
|
I know we haven't reached 48 hours, would y'all be okay with fast-tracking? cc @nodejs/nodejs-website 👍 / 👎 |
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Sorry, I didn't see your ping earlier 😓 It seems like now it's all good right? 🙂 And regarding the failure (https://github.com/nodejs/nodejs.org/actions/runs/16154755332/job/45594542160#step:11:73), I am guessing that this was the bit causing the failure: I wonder if this could have just been a github hiccup 🤔 |






This PR adds nice badges to the home page with current versions and link to blog posts, which are the same as the changelog.
Closes #7889