Node 8

[calvinmetcalf]

No description provided.

[calvinmetcalf]

ok I need to fix the Stream._isUint8Array and similar stuff

[mcollina]

There is a PR waiting to me merged for this.

cc @addaleax for the other things

[calvinmetcalf]

I know how to add them I just didn't get around to it before I went home

…

On Fri, Jun 9, 2017, 4:43 PM Matteo Collina ***@***.***> wrote: There is a PR waiting to me merged for this. cc @addaleax <https://github.com/addaleax> for the other things — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#290 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE4n9xWKmm3F2rOsgOkrZJfYjdITrfQks5sCa58gaJpZM4N1xEg> .

[calvinmetcalf]

and we are green (though I need to rebase it on top of the other pull)

[mcollina]

@calvinmetcalf I've added #255 commit in here. It should be good to go.

[calvinmetcalf]

ok bumped it so it should hopfully build

[mcollina]

I think we should release it as 2.3.0. Let's do this next week, so that @nodejs/streams might have time to review it (I would also be at home and not traveling, in case we need to last-minute bugfixes)

[calvinmetcalf]

ok sounds good

[addaleax]

I looked over the patch and nothing seemed to stick out … I might not have time for a full review but this seems fine to me.

[addaleax]

We might want to include something like nodejs/node#13760.

[mcollina]

I think we should wait for that to be released

[calvinmetcalf]

ok I'll plan on publishing this soon