build/test-replacements.js: fix typo.#415
Merged
mcollina merged 1 commit intonodejs:masterfrom Oct 24, 2019
XhmikosR:master-xmr-typos
Merged
build/test-replacements.js: fix typo.#415mcollina merged 1 commit intonodejs:masterfrom XhmikosR:master-xmr-typos
mcollina merged 1 commit intonodejs:masterfrom
XhmikosR:master-xmr-typos
Conversation
mcollina
reviewed
Aug 10, 2019
Member
mcollina
left a comment
There was a problem hiding this comment.
can you remove the test fix? Those are imported from Node core, so you should send that change there.
Contributor
|
@mcollina I was just looking at that; the typo (and surrounding code) doesn't exist in node core. It seems our tests are a bit outdated? https://github.com/nodejs/node/blob/master/test/parallel/test-stream2-unpipe-drain.js |
Contributor
Author
|
I have already made upstream patches and trying to fix the typos across the whole ecosystem :) |
Member
Contributor
Author
|
@mcollina: done |
Contributor
Author
|
@mcollina friendly ping |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.