This repository was archived by the owner on May 13, 2019. It is now read-only.
src: adjust generation of web pages for nodejs.org#39
Closed
mhdawson wants to merge 1 commit intonodejs:masterfrom
Closed
src: adjust generation of web pages for nodejs.org#39mhdawson wants to merge 1 commit intonodejs:masterfrom
mhdawson wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
|
@addaleax can you review and L.G.T.M or comment as appropriate. Once this lands then I'll update the nightly job to clone the testing repo instead of yours. |
addaleax
approved these changes
Nov 1, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM (but only looked at the diff)
|
|
||
| <div class="mdl-layout__drawer"> | ||
| <nav class="mdl-navigation"> | ||
| <a class="mdl-navigation__link" href="https://github.com/nodejs/node">Node.js Core</a> |
Member
There was a problem hiding this comment.
I think the line after this one (link to https://github.com/addaleax/node-core-coverage) can be removed
Member
Author
There was a problem hiding this comment.
Thanks will validate and then remove/land if still ok.
Adjust the generateion of the summary web page for the coverage data to fit the nodejs.org look and feel.
mhdawson
added a commit
that referenced
this pull request
Nov 4, 2016
Adjust the generation of the summary web page for the coverage data to fit the nodejs.org look and feel. PR-URL: #39 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
Author
|
Landed as ec151b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the generateion of the summary web page for the
coverage data to fit the nodejs.org look and feel.
Change this file so that it generates format as shown at https://coverage.nodejs.org