Conversation
Port over PR from node core. It will not be possible to land these changes on core due to ecosystem breakage. Refs: nodejs/node#39520
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
- Coverage 99.57% 98.52% -1.06%
==========================================
Files 26 27 +1
Lines 2132 2230 +98
==========================================
+ Hits 2123 2197 +74
- Misses 9 33 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2805b1f to
7334d8c
Compare
37557e3 to
5a3ab2e
Compare
8d744a2 to
d5e1f98
Compare
Ethan-Arrowood
approved these changes
Jul 30, 2021
Collaborator
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
LGTM - do you want to make the type updates as well? Shouldn't be hard for this change
szmarczak
reviewed
Jul 30, 2021
mcollina
reviewed
Jul 30, 2021
Member
mcollina
left a comment
There was a problem hiding this comment.
Code looks good. I would recommend we mention what methods will be available in the docs. The .json() method might also deserve a special mention in the README
Member
Author
|
Fixed |
mcollina
reviewed
Jul 31, 2021
Member
Author
|
master PR [bench:run] │ Tests │ Samples │ Result │ Tolerance │ Difference with slowest │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - no keepalive │ 10 │ 6.43 req/sec │ ± 0.98 % │ - │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - keepalive │ 10 │ 6.85 req/sec │ ± 1.93 % │ + 6.42 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - pipeline │ 10 │ 63.27 req/sec │ ± 2.41 % │ + 883.47 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - stream │ 10 │ 67.86 req/sec │ ± 1.31 % │ + 954.73 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - request │ 10 │ 68.78 req/sec │ ± 2.16 % │ + 969.07 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - dispatch │ 10 │ 73.52 req/sec │ ± 1.72 % │ + 1042.76 % │ |
Member
Author
|
@mcollina doesn't seem to have any significant perf regression. |
ronag
added a commit
to nodejs/node
that referenced
this pull request
Aug 2, 2021
This reverts commit 8306051. PR-URL: #39589 Refs: nodejs/undici#907 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 2, 2021
Adds did read accessor used to determine whether a readable has been read from. PR-URL: #39589 Refs: nodejs/undici#907 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 16, 2021
Adds did read accessor used to determine whether a readable has been read from. PR-URL: #39589 Refs: nodejs/undici#907 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 4, 2021
Adds did read accessor used to determine whether a readable has been read from. PR-URL: #39589 Refs: nodejs/undici#907 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* stream: implement body mixin on Readable Port over PR from node core. It will not be possible to land these changes on core due to ecosystem breakage. Refs: nodejs/node#39520 * fixup: tests * fixup * fixup * fixuP * fixuP * fixup: remove node specific stuff * fixup: formData * fixup: simplify * fixup * fixup * fixup * fixup: README * fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* stream: implement body mixin on Readable Port over PR from node core. It will not be possible to land these changes on core due to ecosystem breakage. Refs: nodejs/node#39520 * fixup: tests * fixup * fixup * fixuP * fixuP * fixup: remove node specific stuff * fixup: formData * fixup: simplify * fixup * fixup * fixup * fixup: README * fixup
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port over PR from node core. It will not be possible to land
these changes on core due to ecosystem breakage.
Refs: nodejs/node#39520