Conversation
This is a good idea for libraries in general, and helps with tracking memory allocated by uvwasi in Node.js. The allocator struct format is identical to the one used by nghttp2 and related libraries, which makes things a bit easier because we’ve added generic support for that format in the QUIC repo.
3 tasks
cjihrig
approved these changes
Dec 1, 2019
Collaborator
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM.
I think the answer is "yes" but double checking... does https://travis-ci.com/nodejs/node/jobs/261846786 include Node's wasi test suite?
tniessen
approved these changes
Dec 1, 2019
Member
Author
@cjihrig Travis runs the |
Collaborator
|
Cool. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a good idea for libraries in general, and helps with tracking
memory allocated by uvwasi in Node.js.
The allocator struct format is identical to the one used by nghttp2
and related libraries, which makes things a bit easier because we’ve
added generic support for that format in the QUIC repo.