Conversation
watilde
approved these changes
Feb 14, 2018
Member
|
いいですね :) cc @Leko |
hiroppy
approved these changes
Feb 14, 2018
Member
Author
|
@abouthiroppy AZS! 自分もそこ気になっています 😓 依存 css ライブラリの tacit の方を直すか、この repo 内で修正するか検討して修正します |
Leko
reviewed
Feb 14, 2018
Member
Leko
left a comment
Leko
left a comment
There was a problem hiding this comment.
記事ありがとうございます！細かいとこですが１つ見つけましたのでコメント 👀
source/news/2018/leko.md
Outdated
|
|
||
| 昨年のNode学園祭スピーカ [Leko][]さんが、Node.js の Collaborator になりました。 | ||
|
|
||
| [Leko][]さんは昨年のNode学園祭の Code and Learn セッションで初めて Node.js にコントリビュートを開始し、その後継続的にコントリビュートを続けた結果、2018年2月に正式に Node.js の Collaborator に迎え入れられました 🎉 |
Member
There was a problem hiding this comment.
PR読み返して見たら、2月ではなく1月にコラボレータのPR上げてました！
nodejs/node#18117
Member
Author
There was a problem hiding this comment.
なるほどです、では1月に update しますー、
実は、何をもって、就任日なのかの根拠が突き詰めるとよくわからなかったのですよね・・・
Member
There was a problem hiding this comment.
確かに。
私はPRがマージされた瞬間なのかな、と思ってましたが他の方の見解も聞いて見たいです
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
表現のチェックなどよろしくお願いします 🙇