Changed integers.java constants location and implemented constants in file#237
Open
SameerM123 wants to merge 1 commit intophishman3579:masterfrom
Open
Changed integers.java constants location and implemented constants in file#237SameerM123 wants to merge 1 commit intophishman3579:masterfrom
SameerM123 wants to merge 1 commit intophishman3579:masterfrom
Conversation
SameerM123
commented
Oct 30, 2024
| @@ -9,9 +9,15 @@ public class Integers { | |||
| private static final BigDecimal ZERO = new BigDecimal(0); | |||
| private static final BigDecimal TWO = new BigDecimal(2); | |||
|
|
|||
Author
There was a problem hiding this comment.
Constants start from here now
|
|
||
| public static final String toBinaryUsingDivideAndModulus(int numberToConvert) { | ||
| int integer = numberToConvert; | ||
| if (integer<0) throw new IllegalArgumentException("Method argument cannot be negative. number="+integer); |
Author
There was a problem hiding this comment.
Rest of code is formatting issues that bothered me when trying to implement the constants.
Author
There was a problem hiding this comment.
As well as implementing constants obviously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed integers.java constants location and implemented constants in file, according to assignment instructions