Autotools: Add libtool --silent option to phpize#15703
Closed
petk wants to merge 2 commits intophp:masterfrom
Closed
Autotools: Add libtool --silent option to phpize#15703petk wants to merge 2 commits intophp:masterfrom
petk wants to merge 2 commits intophp:masterfrom
Conversation
When building PHP extensions with phpize there is a lot of additional log output done by libtool in the make step that cannot be turned off. This syncs the php-src build and phpize by enabling the Libtool --silent option.
devnexen
approved these changes
Sep 2, 2024
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
lgtm, php 9 milestone perhaps tough ?
Member
Author
Yes, agreed. Added. |
Member
Author
|
In the meantime I've discovered that some packagers have even patches to enable the additional libtool output for php-src. Probably it isn't that problematic to have some additional info when building with phpize. And probably it could be enabled in the configure.ac instead. I'm simply closing this one for now and considering it as a "feature" for phpize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building PHP extensions with phpize there is a lot of additional log output done by libtool in the make step that cannot be turned off. This syncs the php-src build and phpize by enabling the Libtool --silent option.
This can wait for PHP after 8.4 version, otherwise the default output by
makeis almost always sufficient. The php-src's configure.ac already has this option set but phpize didn't have it yet.