-
Notifications
You must be signed in to change notification settings - Fork 8k
Unify push & nightly workflows #21172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iluuu1994
wants to merge
10
commits into
php:master
Choose a base branch
from
iluuu1994:unify-push-nightly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+249
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce label-based opt-in and opt-out mechanism for jobs.
I'll need to make sure this doesn't break the nightly cron.
b57f3bf to
35c0da2
Compare
asan && !comprehensive doesn't require setup, so the negation would be !asan || comprehensive.
This was referenced Feb 10, 2026
"Enable all" -> "All jobs" "Disable all" -> "No jobs" "Comprehensive" -> "All variations"
This will be improved for phpGH-14154 anyway.
This is slower than I anticipated
The benchmarking job is independant for push, for now at least.
b0eadd1 to
1240f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce label-based opt-in and opt-out mechanism for jobs.
TODOs: