ext/session/mod_mm: initialize mm instance in open handler #21192
+36
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n MINIT This remove access to the globals that could very much change during the execution of the script and prior to opening the session handler
Member
|
Will this not cause race conditions in zts? |
Member
Author
The MM module does not support ZTS and has a preprocessor error defined: #ifdef ZTS
# error mm is not thread-safe
#endif |
Member
|
that s one of the reason I wanted to move away from libmm ... this and how very obsolete it is. |
Member
|
do you plan any more change @Girgias ? |
devnexen
approved these changes
Feb 11, 2026
devnexen
reviewed
Feb 11, 2026
| } | ||
|
|
||
| char euid[30]; | ||
| size_t euid_len = slprintf(euid, sizeof(euid), "%d", geteuid()); |
Member
There was a problem hiding this comment.
one little nit not related to your change, uid_t is unsigned int on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than doing this in MINIT.
This remove access to the globals that could very much change during the execution of the script and prior to opening the session handler.