Fix replace clause of select statement with FOR UPDATE

[MoonE]

Fixes phpmyadmin/phpmyadmin#17190

Replaces _END_OPTIONS with the actual names from here:

sql-parser/src/Statements/SelectStatement.php

Lines 84 to 228 in 29f982a

	public static $END_OPTIONS = [
	'FOR UPDATE' => 1,
	'LOCK IN SHARE MODE' => 1,
	];
	/**
	* The clauses of this statement, in order.
	*
	* @see Statement::$CLAUSES
	*
	* @var array<string, array<int, int|string>>
	* @psalm-var array<string, array{non-empty-string, (1|2|3)}>
	*/
	public static $CLAUSES = [
	'SELECT' => [
	'SELECT',
	2,
	],
	// Used for options.
	'_OPTIONS' => [
	'_OPTIONS',
	1,
	],
	// Used for selected expressions.
	'_SELECT' => [
	'SELECT',
	1,
	],
	'INTO' => [
	'INTO',
	3,
	],
	'FROM' => [
	'FROM',
	3,
	],
	'FORCE' => [
	'FORCE',
	1,
	],
	'USE' => [
	'USE',
	1,
	],
	'IGNORE' => [
	'IGNORE',
	3,
	],
	'PARTITION' => [
	'PARTITION',
	3,
	],
	'JOIN' => [
	'JOIN',
	1,
	],
	'FULL JOIN' => [
	'FULL JOIN',
	1,
	],
	'INNER JOIN' => [
	'INNER JOIN',
	1,
	],
	'LEFT JOIN' => [
	'LEFT JOIN',
	1,
	],
	'LEFT OUTER JOIN' => [
	'LEFT OUTER JOIN',
	1,
	],
	'RIGHT JOIN' => [
	'RIGHT JOIN',
	1,
	],
	'RIGHT OUTER JOIN' => [
	'RIGHT OUTER JOIN',
	1,
	],
	'NATURAL JOIN' => [
	'NATURAL JOIN',
	1,
	],
	'NATURAL LEFT JOIN' => [
	'NATURAL LEFT JOIN',
	1,
	],
	'NATURAL RIGHT JOIN' => [
	'NATURAL RIGHT JOIN',
	1,
	],
	'NATURAL LEFT OUTER JOIN' => [
	'NATURAL LEFT OUTER JOIN',
	1,
	],
	'NATURAL RIGHT OUTER JOIN' => [
	'NATURAL RIGHT JOIN',
	1,
	],
	'WHERE' => [
	'WHERE',
	3,
	],
	'GROUP BY' => [
	'GROUP BY',
	3,
	],
	'_GROUP_OPTIONS' => [
	'_GROUP_OPTIONS',
	1,
	],
	'HAVING' => [
	'HAVING',
	3,
	],
	'ORDER BY' => [
	'ORDER BY',
	3,
	],
	'LIMIT' => [
	'LIMIT',
	3,
	],
	'PROCEDURE' => [
	'PROCEDURE',
	3,
	],
	'UNION' => [
	'UNION',
	1,
	],
	'EXCEPT' => [
	'EXCEPT',
	1,
	],
	'INTERSECT' => [
	'INTERSECT',
	1,
	],
	'_END_OPTIONS' => [
	'_END_OPTIONS',
	1,
	],

[MoonE]

When merging to master (PHP >= 7.3) the if is no long needed

Suggested change

	if (static::$END_OPTIONS !== []) {
	array_push($clauses, ...array_keys(static::$END_OPTIONS));
	}
	array_push($clauses, ...array_keys(static::$END_OPTIONS));

https://www.php.net/manual/en/function.array-push.php

[williamdes]

When merging in master, this key changes name