Add handling of index hints on join clauses too. Fixes #593 and #497.#613
Closed
niconoe- wants to merge 2 commits intophpmyadmin:masterfrom
Closed
Add handling of index hints on join clauses too. Fixes #593 and #497.#613niconoe- wants to merge 2 commits intophpmyadmin:masterfrom
niconoe- wants to merge 2 commits intophpmyadmin:masterfrom
Conversation
Contributor
Author
|
AFAIK, all mutants here are actually from previous states, so I'm not sure it's the role of this PR to try to kill em. What do you think about @williamdes ? |
Member
yeah okay, no worries then. Thank you for checking |
williamdes
approved these changes
Feb 3, 2025
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
This looks okay
Please add the fixes lines to the PR description
Member
|
Closing this in favor of #614. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
Fixes #497
This is to be merged in the
masterbranch. After taking another look, it does not seem to be a BC Break as I thought in #593, as the indexHints should just be added from the JOIN clause handling, not being removed from the SELECT statement.I'll do another PR for the 5.10.x and 5.11.x versions, as this one uses new features from v6 the v5 doesn't have yet.