This repository was archived by the owner on Dec 1, 2021. It is now read-only.
Merged
Conversation
Adding Power & Updating the go versions to 1.13/1.14/1.15 as lower versions are not supported.
davecheney
suggested changes
Dec 7, 2020
Member
davecheney
left a comment
davecheney
left a comment
There was a problem hiding this comment.
Thank you for the change. I’d be happy to take a PR to test only on go 1.14 and 1.15.
There is nothing platform specific about the errors package that would benefit from testing on power, please remove that part of the pr. Thank you
Removing go 1.13 as desired in the comment section,
Contributor
Author
|
@davecheney As advised by you, I have re-run the Tests with go-1.14/1.15., |
Contributor
Author
|
@davecheney Checking herewith if you have any further queries on this PR? Thank you !! |
Member
Thank you. I'm waiting on you to revert the change to the architectures, please see #234 (review) |
As desired taking out the power(ppc64le) related support.,
davecheney
approved these changes
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Power & Updating the go versions to 1.13/1.14/1.15 as lower versions are not supported.
Adding power support ppc64le with Continues Integration/testing so that code remains architecture independent.
This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3.
The build is successful on both arch: amd64/ppc64le, please find the Travis Link below.
https://travis-ci.com/github/santosh653/errors
Please let me know if you need any further details?
Thank You !!