Use isArrayOrTypedArray in gl_format_color.js#2596
Merged
Conversation
Collaborator
|
Nice and easy - 💃 No guarantee there aren't others lingering out there... I wonder if we can do something perhaps in the react-noop tests like crawl each figure for numeric arrays, convert them all to typed arrays, and verify that nothing fails? I guess that wouldn't have caught this one though, as it didn't cause an error, just failed to use the array, and it doesn't seem like there's any generic way to tell that other than I guess image tests... Or we can just let @jmmease tell us what else we missed 😉 |
Contributor
Author
This gets my vote 😄 Or this #913 or probably the best solution from #1784 (comment) |
Contributor
|
Works for me 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2591 - one
Array.isArray->Lib.isArrayOrTypedArraythat slipped through in #2388cc @alexcjohnson @dy