Fix issue causing empty ScatterGL plots when using text elements #7563
Fix issue causing empty ScatterGL plots when using text elements #7563
Conversation
|
Also should resolve plotly/plotly.py#5336 but that won't be closed until this fix is included in Plotly.py. |
cdf9dcc to
443b385
Compare
camdecoster
left a comment
There was a problem hiding this comment.
This worked for me. I made a couple of small comments for formatting changes.
tasks/compress_attributes.js
Outdated
| makeStringRegex('hrName') | ||
| ]; | ||
|
|
||
| var esbuildPluginStripMeta = { |
There was a problem hiding this comment.
| var esbuildPluginStripMeta = { | |
| const esbuildPluginStripMeta = { |
|
Another bonus: Possibly reduces build time (this is just one data point, wanted to do a sanity check to make sure it wasn't massively slower)
|
|
faster is gooder |
|
This bug should have been caught by the CI, but it turns out that we weren't actually running the (And the tests on this branch I just created prove that many baseline images fail to generate when we are using the correct build process in the CI.) |
|

Closes #7353 , #7441
Uncaught TypeError: systemFontKeywords.indexOf is not a functioncss-system-font-keywords(sub-)dependency not being included properly during the build processThanks to @ayjayt for helping diagnose and to @WeisSeb and @pawel-paciorek-at-metrohm for reporting.
Minimal HTML/JS example demonstrating issue
(Based on @WeisSeb 's example in #7353)
Should look like:

Steps for testing
npm i && npm run buildplotly.js/directory and visit in your browser