Add prebuilt assets when installing from sdist#3231
Merged
nicolaskruchten merged 1 commit intoplotly:masterfrom Jun 11, 2021
Merged
Add prebuilt assets when installing from sdist#3231nicolaskruchten merged 1 commit intoplotly:masterfrom
nicolaskruchten merged 1 commit intoplotly:masterfrom
Conversation
Contributor
Author
|
I tested it locally by changing the setup.py in the tar.gz. It may be worth adding some tests. |
8 tasks
Contributor
|
Thank you again! I'll get this rolled into the next RC |
Contributor
|
A couple of additional questions for you in terms of expected behaviour:
|
Contributor
Author
To achieve that, the setup command will need to be modified (by default the editable mode does not copy any files in the python system tree). But I'm not sure this is the best idea. I would recommend running these two commands instead: See documentation
If plotly was not installed, they need to restart the kernel and refresh the frontend. |
Contributor
|
Thanks! I'm hoping to release this this week :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3230