Resolves: #[1417] Value Now Compares to missingFloat Variable#1441
Draft
ericahin wants to merge 1 commit intoprocessing:mainfrom
Draft
Resolves: #[1417] Value Now Compares to missingFloat Variable#1441ericahin wants to merge 1 commit intoprocessing:mainfrom
ericahin wants to merge 1 commit intoprocessing:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared variable "missingFloat." This was labeled as a TODO. This maintains consistency throughout the document so is anything were to change, this comparison would stay consistent with the rest of the file.
I tested using the ./gradlew test command, all tests were passed by this code, and branch is up-to-date.