Refer to ESM modules, not CJS ones#277
Merged
JordanMartinez merged 5 commits intopurescript:masterfrom Jun 10, 2022
JordanMartinez:fix-compile-path
Merged
Refer to ESM modules, not CJS ones#277JordanMartinez merged 5 commits intopurescript:masterfrom JordanMartinez:fix-compile-path
JordanMartinez merged 5 commits intopurescript:masterfrom
JordanMartinez:fix-compile-path
Conversation
NOTE: this doesn't quite work
Contributor
Author
|
I'll have to complete this another day. |
thomashoneyman
approved these changes
Jun 10, 2022
MonoidMusician
approved these changes
Jun 10, 2022
Contributor
MonoidMusician
left a comment
There was a problem hiding this comment.
Looks good. Two minor things:
- I think
client/setBase.mjscan be removed now? - Don't forget to update the README to not mention
basenow ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #276.
#276 is caused by two issues:
importstatements as we could just use thebaseelement. However, that means we send a request to the wrong domain.https://compile.purescript.org/output/*/.jswould return the files found in/var/www/trypurescript/staging/.psci_modules/node_modules/$1. This is no longer the place where such files are outputted in an ESM world (I'm not sure why). Rather, they're outputted in/var/www/trypurescript/staging/.psci_modules/$1.To summarize:
Checklist: