Show compiled JS based on query params only#296
Merged
JordanMartinez merged 3 commits intopurescript:masterfrom Aug 13, 2022
JordanMartinez:jam/view-code-via-link
Merged
Show compiled JS based on query params only#296JordanMartinez merged 3 commits intopurescript:masterfrom JordanMartinez:jam/view-code-via-link
JordanMartinez merged 3 commits intopurescript:masterfrom
JordanMartinez:jam/view-code-via-link
Conversation
natefaubion
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
I noticed that using the
view=output&js=truequery params (e.g. https://try.purescript.org/?view=output&js=true) don't show the compiled JavaScript but rather shows a loading screen for forever. This is annoying because I can't just show others what PureScript's output looks like when they're curious.This fixes that.
Checklist: