Conversation
|
(I added a change to remove an |
pgjones
left a comment
pgjones
left a comment
There was a problem hiding this comment.
Some minor versioning comments. I think we state 3.6+ given 3.5 is EOL.
Otherwise this is great, thanks!
| ---------------- | ||
|
|
||
| * Requirements: Python 2.7 or Python 3.5+ (PyPy works great) | ||
| * Requirements: Python 3.5+ (PyPy works great) |
| @@ -0,0 +1,2 @@ | |||
| Python 2.7 and PyPy 2 support is removed. h11 now requires Python>=3.5 including PyPy 3. | |||
| # This means, just install *everything* you see under h11/, even if it | ||
| # doesn't look like a source file, so long as it appears in MANIFEST.in: | ||
| include_package_data=True, | ||
| python_requires=">=3.5", |
| "Programming Language :: Python :: 2.7", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3 :: Only", | ||
| "Programming Language :: Python :: 3.5", |
Sounds good to me, would definitely be a little nicer for typing. Should I open an issue for discussion or just add it here? (Maybe some dependents still want to support Python 3.5)
I'll mark this PR as blocked on #115/0.12.0, will update after they're done. |
|
(It would be nice to test 3.9 in CI as well) |
I reckon we should maybe get these done the other way around, no? A progression that looks sensible to me is:
|
|
Yea, I think that is the better flow. |
|
Merged via command line (fixing conflicts). |
4 participants
Blocked on #115 / 0.12.0 release, will be updated afterwards.
Fixes #114.
Python 2 support in this library is not too onerous, the main reason for doing this is to allow using newer Python features like inline type annotations.
In the documentation/README updates I assume that this will be released in a 0.12.x series rather than the latest 0.11.x series which supports Python 2. I think it would be good to branch off 0.11.x just in case we ever want to backport some bug fixes to a Python 2-compatible version.
I updated whatever I could find except for the `ReceiveBuffer. According to the comment there it can be simplified after Python 2 is dropped but needs some care. I will look at it in a separate PR unless someone else wants to update this part.