Add checks to pre-commit#7421
Merged
radarhere merged 8 commits intopython-pillow:mainfrom Sep 28, 2023
Merged
Conversation
radarhere
reviewed
Sep 26, 2023
| - id: end-of-file-fixer | ||
| exclude: ^Tests/images/ | ||
| - id: trailing-whitespace | ||
| exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/ |
Member
There was a problem hiding this comment.
Suggested change
| exclude: ^.github/.*TEMPLATE|^Tests/(fonts|images)/ | |
| exclude: ^.github/.*TEMPLATE|^Tests/(fonts|icc|images)/ |
?
Member
Author
There was a problem hiding this comment.
Hmm, it is fixing the text file in this directory and not touching the binaries. Shall we leave it as is, until it comes up?
radarhere
reviewed
Sep 26, 2023
Member
For the record, or maybe just as a note to self, this is recommended at https://github.com/psf/black/blob/3dcacdda0d7f69a1705f3e2a151c24a6cf004171/.pre-commit-hooks.yaml#L1-L2
|
Member
Author
|
Also in the docs here: https://black.readthedocs.io/en/stable/integrations/source_version_control.html |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-executables-have-shebangsand remove executable flagsend-of-file-fixer, excludingTests/images/trailing-whitespace, excluding some templates, test fonts and images