Skip to content

Removed unused code#7434

Merged
hugovk merged 1 commit intopython-pillow:mainfrom
radarhere:blp
Oct 2, 2023
Merged

Removed unused code#7434
hugovk merged 1 commit intopython-pillow:mainfrom
radarhere:blp

Conversation

@radarhere
Copy link
Member

save_all is not used in the following code.

def _save(im, fp, filename, save_all=False):
if im.mode != "P":
msg = "Unsupported BLP image mode"
raise ValueError(msg)
magic = b"BLP1" if im.encoderinfo.get("blp_version") == "BLP1" else b"BLP2"
fp.write(magic)
fp.write(struct.pack("<i", 1)) # Uncompressed or DirectX compression
fp.write(struct.pack("<b", Encoding.UNCOMPRESSED))
fp.write(struct.pack("<b", 1 if im.palette.mode == "RGBA" else 0))
fp.write(struct.pack("<b", 0)) # alpha encoding
fp.write(struct.pack("<b", 0)) # mips
fp.write(struct.pack("<II", *im.size))
if magic == b"BLP1":
fp.write(struct.pack("<i", 5))
fp.write(struct.pack("<i", 0))
ImageFile._save(im, fp, [("BLP", (0, 0) + im.size, 0, im.mode)])

It isn't necessary. See JpegImagePlugin for example.

def _save(im, fp, filename):

@hugovk hugovk merged commit 3bbd896 into python-pillow:main Oct 2, 2023
@radarhere radarhere deleted the blp branch October 2, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants