Fix for Python 3.13: explicitly include unistd.h#7535
Merged
hugovk merged 3 commits intopython-pillow:mainfrom Nov 11, 2023
Merged
Fix for Python 3.13: explicitly include unistd.h#7535hugovk merged 3 commits intopython-pillow:mainfrom
unistd.h#7535hugovk merged 3 commits intopython-pillow:mainfrom
Conversation
Contributor
|
Isn't |
Contributor
|
On Windows, |
radarhere
approved these changes
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
unistd.hto uselseekChanged in Python 3.13:
So we need to
#include <unistd.h>forsrc/libImaging/TiffDecode.cwhich useslseek.Also add Python 3.13 to the CI for Ubuntu, macOS and Windows. We need to skip
cffi, it's not ready for 3.13.3.13 is in alpha, so we can expect things still to change. I'm fine leaving it out of the CI until later or beta, but it could be useful to get early feedback. If any sudden failures turn up, we can always comment it out until we get it sorted (in Pillow or upstream in CPython, as necessary).