Restored testing of ImageFont class#7647
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 29, 2023
Merged
Conversation
nulano
approved these changes
Dec 28, 2023
Contributor
There was a problem hiding this comment.
I thought using a not-fully-initialized instance of ImageFont would not be a good test, but adding ImageFont.MAX_STRING_LENGTH = None, I see that this fails with AttributeError instead, confirming this fixes the test.
As far as testing the rest of ImageFont (i.e. coverage after the string length check), I have since found test_font_pcf.py uses an instance initialized with ImageFont.load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7244 added the following test code
Pillow/Tests/test_imagefont.py
Lines 1056 to 1060 in 78b96c0
At the time, this was testing the "better than nothing" font that uses ImageFont class. However, #7354 changed the default font in some environments, so the ImageFont class would no longer have been covered in this test.
This PR fixes that by creating an instance of the ImageFont class directly.