Remove execute bit from setup.py#7760
Merged
radarhere merged 4 commits intopython-pillow:mainfrom Jan 30, 2024
Merged
Conversation
Contributor
|
Would it be a good idea to also remove the shebang? Line 1 in 529487c |
Member
Author
|
Good idea! Our pre-commit has a "check that executables have shebangs" check, but didn't have the reverse. So I've added the "check that scripts with shebangs are executable" check and removed the shebangs from some other files. Plus removed the shebang and exec bit from one |
radarhere
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoking
setup.pydirectly is deprecated:Instead, something like
pip install -e .orpip install .should be used:See #5896 and linked PRs for related changes.