Test on macOS M1 where available#7766
Merged
radarhere merged 2 commits intopython-pillow:mainfrom Jan 30, 2024
Merged
Conversation
radarhere
approved these changes
Jan 30, 2024
5 tasks
2 tasks
shinny-mayanqiong
added a commit
to shinnytech/tqsdk-ci
that referenced
this pull request
May 31, 2024
Member
Author
|
GitHub Actions now has Python 3.9 available on both actions/setup-python#696 (comment)
That's 1m22s quicker on M1 :) Shall we switch 3.9 from Intel to M1? Or shall we keep at least one job on Intel to verify tests still pass on the older architecture? I favour this, it's not such a huge time saving and it's good to have more test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions now has macOS M1 runners:
Python 3.9.1 was the first to support Apple Silicon:
But 3.9 is not currently available for M1:
So let's test 3.10-3.13 on M1, and 3.8-3.9 on Intel.
I bumped the
PYTHONOPTIMIZEjobs from 3.8/3.9 to 3.10/3.11 to avoid complicating the matrix includes/excludes. And needed to install Ghostscript, it wasn't already on the image.Here's how long it took to test on M1 (left) and Intel (right). M1 is faster for all, around twice as fast for 3.13 and PyPy3.10, and nearly three times as fast for PyPy3.9!
That's reduced from about 49 minutes to 25 minutes!