Skip AppVeyor builds for irrelevant files#7909
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Mar 27, 2024
Merged
Conversation
radarhere
reviewed
Mar 27, 2024
radarhere
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to GitHub Actions, we can skip AppVeyor builds when irrelevant files are changed.
For example, we don't need to test Windows for changes that are exclusively docs, or cibuildwheel.
This is based on GHA's
test-windows.yml:Pillow/.github/workflows/test-windows.yml
Lines 7 to 12 in fac81d6
Except widened one skip to the whole
.githubdirectory.Docs: https://www.appveyor.com/docs/how-to/filtering-commits/#commit-files-github-and-bitbucket-only
I've not tried this out before on AppVeyor. We only have two jobs on AppVeyor, and they run in serial (max parallel runners=1), but it's not causing a particular bottleneck compared to the big GHA matrix. However, one minor annoyance, in PRs like #7905, we skip the regular tests on GHA, but AppVeyor still runs, meaning we get a code coverage report of ~50%.