Add type hints for Image.open, Image.init, and Image.Image.save#7944
Merged
radarhere merged 3 commits intopython-pillow:mainfrom Apr 6, 2024
Merged
Add type hints for Image.open, Image.init, and Image.Image.save#7944radarhere merged 3 commits intopython-pillow:mainfrom
Image.open, Image.init, and Image.Image.save#7944radarhere merged 3 commits intopython-pillow:mainfrom
Conversation
Member
|
Hmmm, jinx #7943 ? |
Image.open and Image.initImage.open, Image.init, and Image.Image.save
hugovk
approved these changes
Apr 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7941
While the
Image.openfunction is currently marked as returning anImageobject, it does so by calling a factory function fromOPEN, which is marked as returning anImageFile:Pillow/src/PIL/Image.py
Lines 222 to 228 in e8ab564
The
acceptfunction usually returns abool, but I found one case (webp) where it can return astrinstead to be used as a warning.