Conversation
hugovk
reviewed
Apr 25, 2024
src/_imagingcms.c
Outdated
Comment on lines
222
to
224
| } else if (strcmp(PILmode, "RGBA;16B") == 0) { | ||
| return TYPE_RGBA_16; | ||
| } else if (strcmp(PILmode, "CMYK") == 0) { |
Member
There was a problem hiding this comment.
More of a style issue: these all return, I think it reads a little cleaner to remove the elses:
Suggested change
| } else if (strcmp(PILmode, "RGBA;16B") == 0) { | |
| return TYPE_RGBA_16; | |
| } else if (strcmp(PILmode, "CMYK") == 0) { | |
| } | |
| if (strcmp(PILmode, "RGBA;16B") == 0) { | |
| return TYPE_RGBA_16; | |
| } | |
| if (strcmp(PILmode, "CMYK") == 0) { |
etc.
Member
Author
There was a problem hiding this comment.
Ok, I've updated the commit.
src/_imagingcms.c
Outdated
| // LabX equivalent like ALab, but not reversed -- no #define in lcms2 | ||
| return (COLORSPACE_SH(PT_LabV2) | CHANNELS_SH(3) | BYTES_SH(1) | EXTRA_SH(1)); | ||
| } | ||
| else { |
Member
There was a problem hiding this comment.
And ditch and dedent this block?
Member
Author
There was a problem hiding this comment.
I think I know what you meant, I've updated the commit.
hugovk
approved these changes
Apr 25, 2024
Member
|
Speaking of formatting, anyone interested in adding |
Member
Member
|
Hmmm, I ran it local and got a bunch of additional changes but … cool! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.