Do not detect Ultra HDR images as MPO#8056
Merged
hugovk merged 3 commits intopython-pillow:mainfrom Jun 26, 2024
Merged
Conversation
Member
|
Can we find a smaller image to include in the test suite? cc @bigcat88 |
Contributor
|
I am not the author of that image. Here is the link to the message of author #8052 (comment) where he mentions that he does not have the smaller image ( |
Member
Author
|
@hugovk would you prefer I create a smaller image artificially? |
Member
|
If it's not too difficult and it doesn't feel too hacky? Otherwise the one already here is probably fine. Just keeping an eye on our 46.6 MB sdist. |
Member
Author
|
I've realised that since we're not loading the image, I can just truncate the file leaving only the data that's read in the initial open. The test image is now down to 48kb. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8052
The Ultra HDR format stores its gain map as an additional MPO image. However, as the issue has found, because we do not support Ultra HDR images, the additional image appears incorrectly.
Instead, this PR treats such files as standard JPEGs.
https://developer.android.com/media/platform/hdr-image-format#signal_of_the_format details how this format can be detected.