Improved consistency of XMP handling#8069
Merged
hugovk merged 4 commits intopython-pillow:mainfrom Jun 19, 2024
Merged
Conversation
Contributor
|
Since this change removed the Info is here: bigcat88/pillow_heif#69 Because now I need to either remove the leading byte, which will lead to the fact that if the image is opened and saved, the That will allows me to just remove |
Member
Author
|
Ah, I had presumed I was just removing an unused internal method. I've created #8171. Let us know if you have any feedback. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5076 (comment) is a user who would like to retrieve XMP strings from images. This can be done, but inconsistently between formats.
This PR updates JPEG, TIFF and PNG to create
im.info["xmp"]like WEBP does.Then, given that common location of XMP data, it makes sense to tidy up the code by adding
getxmp()to the Image class, rather than duplicating it for each of supported formats.getxmp()will return an empty dictionary for other formats.