Conversation
hugovk
reviewed
Jun 10, 2024
| entries.append( | ||
| {"type": type, "size": HEADERSIZE + len(stream), "stream": stream} | ||
| ) | ||
| entries.append((type, HEADERSIZE + len(stream), stream)) |
Member
Author
There was a problem hiding this comment.
Once i type hinted the _save method in this plugin, mypy reported
src/PIL/IcnsImagePlugin.py:358: error: Generator has incompatible item type "object"; expected "bool" [misc]
file_length += sum(entry["size"] for entry in entries)
^~~~~~~~~~~~~
src/PIL/IcnsImagePlugin.py:365: error: No overload variant of "write" of "IO" matches argument type "object" [call-overload]
fp.write(entry["type"])
^~~~~~~~~~~~~~~~~~~~~~~
src/PIL/IcnsImagePlugin.py:365: note: Possible overload variants:
src/PIL/IcnsImagePlugin.py:365: note: def write(self, Buffer, /) -> int
src/PIL/IcnsImagePlugin.py:365: note: def write(self, bytes, /) -> int
src/PIL/IcnsImagePlugin.py:370: error: No overload variant of "write" of "IO" matches argument type "object" [call-overload]
fp.write(entry["type"])
^~~~~~~~~~~~~~~~~~~~~~~
src/PIL/IcnsImagePlugin.py:370: note: Possible overload variants:
src/PIL/IcnsImagePlugin.py:370: note: def write(self, Buffer, /) -> int
src/PIL/IcnsImagePlugin.py:370: note: def write(self, bytes, /) -> int
src/PIL/IcnsImagePlugin.py:372: error: No overload variant of "write" of "IO" matches argument type "object" [call-overload]
fp.write(entry["stream"])
^~~~~~~~~~~~~~~~~~~~~~~~~
src/PIL/IcnsImagePlugin.py:372: note: Possible overload variants:
src/PIL/IcnsImagePlugin.py:372: note: def write(self, Buffer, /) -> int
src/PIL/IcnsImagePlugin.py:372: note: def write(self, bytes, /) -> int
Found 4 errors in 1 file (checked 1 source file)
This change fixes it. I can use a named tuple or something if you prefer.
Member
There was a problem hiding this comment.
Thanks. Named tuples are nice, but this is very localised so I think we're fine with a basic tuple here.
Comment on lines
+344
to
+345
| if isinstance(filename, bytes): | ||
| filename = filename.decode("ascii") |
hugovk
approved these changes
Jun 10, 2024
| entries.append( | ||
| {"type": type, "size": HEADERSIZE + len(stream), "stream": stream} | ||
| ) | ||
| entries.append((type, HEADERSIZE + len(stream), stream)) |
Member
There was a problem hiding this comment.
Thanks. Named tuples are nice, but this is very localised so I think we're fine with a basic tuple here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.