Do not create new image when exif_transpose() is used in place#8555
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 27, 2024
Merged
Do not create new image when exif_transpose() is used in place#8555hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
im.transpose()loads the image, calls the coretranspose()method and returns a new image instance.Pillow/src/PIL/Image.py
Lines 2982 to 2994 in 5bff2f3
When
im.transpose()is called fromImageOps.exif_transpose(), if it isin_place, then the image is already loaded, and the new image instance is quickly abandoned.Pillow/src/PIL/ImageOps.py
Lines 701 to 705 in 5bff2f3
So this can be simplified to just calling the core
transpose()method directly.