Improve type checking in tests#8618
Merged
hugovk merged 4 commits intopython-pillow:mainfrom Feb 17, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.
In our test suite, this PR
getpixel(), rather than float orNone, before index access is usedPillow/src/PIL/Image.py
Lines 1680 to 1682 in 0e3f51d
load()does not returnNonebefore pixel access is usedPillow/src/PIL/Image.py
Line 882 in 0e3f51d
paletteis not None before trying to access one of its propertiesPillow/src/PIL/Image.py
Line 555 in 0e3f51d