Pass file handle to ContainerIO#8625
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 27, 2024
Merged
Conversation
b701469 to
aef3aa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.
#7656 set
ContainerIOto receiveIOas the type of the first argument.Pillow/src/PIL/ContainerIO.py
Line 29 in f9767fb
Currently, test_file_container.py passes an image instance to it sometimes - the wrong type.
Pillow/Tests/test_file_container.py
Lines 18 to 19 in f9767fb
This PR fixes that, passing a file handle to it like the rest of the test file does.
Pillow/Tests/test_file_container.py
Lines 41 to 42 in f9767fb