Merged
Conversation
radarhere
reviewed
Feb 17, 2025
.ci/install.sh
Outdated
| # NumPy doesn't support PyPy3.11 | ||
| if [[ $GHA_PYTHON_VERSION != pypy3.11 ]]; then | ||
| python3 -m pip install numpy | ||
| fi |
Member
There was a problem hiding this comment.
From what I see, NumPy works with PyPy 3.11 on both macOS and Ubuntu - https://github.com/radarhere/Pillow/tree/refs/heads/numpy - https://github.com/radarhere/Pillow/actions/runs/13360699763
Member
Author
There was a problem hiding this comment.
Excellent, the previously-failing job passes on a re-run.
https://github.com/hugovk/Pillow/actions/runs/13203963591/job/37329242544
I've rebased the skip out :)
radarhere
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPy v7.3.18 is out:
https://pypy.org/posts/2025/02/pypy-v7318-release.html
#8757 already updated
src/thirdparty/pythoncapi_compat.h, this is how it looked without it:https://github.com/hugovk/Pillow/actions/runs/13203645421/job/36861505207
We also need to skip NumPy for now:
https://github.com/hugovk/Pillow/actions/runs/13203963591/job/36862554511
Also fix some ShellCheck warnings in
.ci/install.sh.