Clear TIFF core image if memory mapping was used for last load#8962
Merged
radarhere merged 3 commits intopython-pillow:mainfrom Jun 10, 2025
Merged
Clear TIFF core image if memory mapping was used for last load#8962radarhere merged 3 commits intopython-pillow:mainfrom
radarhere merged 3 commits intopython-pillow:mainfrom
Conversation
Member
|
Does it make sense to set the c level read-only flag on the image if it's memmapped, and then check if the image is read-only instead? Would the mmap also cause an issue if someone were to try to imagedraw on it? |
Member
Author
|
I've updated the commit to use the Python readonly flag. ImageDraw should be fine, thanks to this code in Lines 78 to 79 in 3c71559 |
Mark the image read-only in the C layer if it's created from a read only buffer
wiredfool
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8961
I've used the test image from the issue, but due to a larger file size, I've placed it in python-pillow/test-images#7. This will fail without that pull request.
Using memory mapping to load one frame, and then not using it for the next frame, is causing a problem. This would be because memory mapping is replacing the core image.
Pillow/src/PIL/ImageFile.py
Lines 324 to 326 in 3c71559
But TiffImagePlugin tries to keep using it afterwards.
Pillow/src/PIL/TiffImagePlugin.py
Lines 1214 to 1223 in 3c71559