gh-92347: Throw a warning when converting a pointer to an iterator#126318
Closed
rruuaanng wants to merge 1 commit intopython:mainfrom
Closed
gh-92347: Throw a warning when converting a pointer to an iterator#126318rruuaanng wants to merge 1 commit intopython:mainfrom
rruuaanng wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
It actually kind of overwhelmed me, the added exception also caused the CI to fail. from test_ctypes/test_values.py
Maybe we can just change the document. |
Contributor
|
Please do not propose PRs prematurely like this. Moreover, test your changes locally before proposing the fix. If you are uncertain how the CI will react, test your changes using a PR on your own fork first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @JelleZijlstra
Since it is implemented in an extension, I added an exception when getting it. Do you think?
📚 Documentation preview 📚: https://cpython-previews--126318.org.readthedocs.build/