gh-126780: Fix ntpath.normpath() for drive-relative paths#126801
Merged
zooba merged 4 commits intopython:mainfrom Nov 21, 2024
Merged
gh-126780: Fix ntpath.normpath() for drive-relative paths#126801zooba merged 4 commits intopython:mainfrom
ntpath.normpath() for drive-relative paths#126801zooba merged 4 commits intopython:mainfrom
Conversation
Contributor
Author
|
cc @zooba, @barneygale |
barneygale
approved these changes
Nov 14, 2024
Contributor
barneygale
left a comment
barneygale
left a comment
There was a problem hiding this comment.
The test cases LGTM but I haven't reviewed the C code. Thanks
ruidazeng
approved these changes
Nov 19, 2024
zooba
added
needs backport to 3.12
|
Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @nineteendo and @zooba, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2024
…thonGH-126801) (cherry picked from commit 60ec854) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Member
|
Not sure if we need to go back to 3.12, but letting the bot decide... guess not! |
|
GH-127103 is a backport of this pull request to the 3.13 branch. |
Contributor
Author
|
Thanks. |
zooba
pushed a commit
that referenced
this pull request
Nov 21, 2024
(cherry picked from commit 60ec854) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ntpath.normpath()for drive-relative paths #126780