Skip to content

Comments

gh-128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative#128983

Merged
encukou merged 4 commits intopython:mainfrom
picnixz:perf/match/cookiejar-128982
Feb 26, 2025
Merged

gh-128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative#128983
encukou merged 4 commits intopython:mainfrom
picnixz:perf/match/cookiejar-128982

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Jan 18, 2025

The function does not anymore rely on a regular expression
to find alphanumeric characters and underscores.
@picnixz picnixz requested a review from vadmium February 12, 2025 11:21
@encukou encukou merged commit 56e1900 into python:main Feb 26, 2025
39 checks passed
encukou added a commit to encukou/cpython that referenced this pull request Feb 26, 2025
…ejar.join_header_words` for an efficient alternative (pythonGH-128983)"

This reverts commit 56e1900.
encukou added a commit that referenced this pull request Feb 26, 2025
…kiejar.join_header_words for an efficient alternative (GH-128983)" and add tests (GH-130584)

* Revert "gh-128982: Substitute regular expression in `http.cookiejar.join_header_words` for an efficient alternative (GH-128983)"

This reverts commit 56e1900.

* Add tests
@picnixz picnixz deleted the perf/match/cookiejar-128982 branch March 1, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants