bpo-43244: GitHub Action builds Python in debug mode on Windows#24914
bpo-43244: GitHub Action builds Python in debug mode on Windows#24914vstinner wants to merge 1 commit intopython:masterfrom vstinner:gha_win_debug
Conversation
|
I didn't check yet if this change makes the CI way slower or not. I wrote this PR since the Windows x64 job of GitHub Actions didn't catch the build error about Py_DebugFlag in test_peg_generator in my previous PR: Hopefully, we have at least one Windows buildbot running in release mode: https://buildbot.python.org/all/#/builders/405 |
The debug mode catchs more bugs but is slower.
|
Oh, test_peg_generator failed. I rebased my PR on top of my commit 57d0a87 fix. test_locale also fails, I don't know why and I don't see why it only fails in debug mode: |
|
The job still fails with: With test_locale re-run in verbose mode, "the total tests duration is 19 min 41 sec. |
|
Oh, test_locale failure seems to be known since 2019: https://bugs.python.org/issue37945 |
|
Without this PR (Python built in release mode), tests take 12 min 19 sec on Windows x64. It should be compared with 19 min 41 sec with this PR. So this PR adds 7 minutes to the CI, it's quite signifiant (1.6x slower). I'm not sure that I would like to make the CI slower on all PRs just because once per year there is a bug not catched by the pre-commit PR. I close the PR. |
The debug mode catchs more bugs but is slower.
https://bugs.python.org/issue43244