bpo-43224: Unpack concrete tuple types into a sequence of types#32030
Closed
serhiy-storchaka wants to merge 1 commit intopython:mainfrom
Closed
bpo-43224: Unpack concrete tuple types into a sequence of types#32030serhiy-storchaka wants to merge 1 commit intopython:mainfrom
serhiy-storchaka wants to merge 1 commit intopython:mainfrom
Conversation
serhiy-storchaka
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
G[*tuple[int, str]] == G[int, str]
serhiy-storchaka
force-pushed
the
unpack-concrete-tuple-types
branch
from
cf4a80f to
bc310d5
Compare
Member
|
I'd rather not do this for the reasons @mrahtz explained elsewhere. Another point: what about |
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
I don't think we should do this (see also @mrahtz's comment at #91162 (comment)):
- It would make
Unpack[tuple[int, str]]not the same as*tuple[int, str]. def f(*args: *tuple[int, str])would end up withintin its__annotations__because of the way we implemented*there.- For runtime users of typing, in my experience it's better to keep information around than to simplify. If we simplify, runtime introspection can't reconstruct what the user meant; if we don't simplify, tool authors can probably deal with it easily.
Contributor
|
+1 to what @JelleZijlstra says. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G[*tuple[int, str]] == G[int, str]
https://bugs.python.org/issue43224