gh-90997: Move CACHE handling into _unpack_opargs#92409
Merged
pablogsal merged 3 commits intopython:mainfrom May 6, 2022
Merged
gh-90997: Move CACHE handling into _unpack_opargs#92409pablogsal merged 3 commits intopython:mainfrom
CACHE handling into _unpack_opargs#92409pablogsal merged 3 commits intopython:mainfrom
Conversation
CACHE handling into _unpack_opargsCACHE handling into _unpack_opargs
Member
Author
|
No client of |
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 20a8e09 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Member
Author
|
Looks like the first few s390x buildbots are indeed happy with this change. |
pablogsal
approved these changes
May 6, 2022
Member
|
Thanks a lot @brandtbucher |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_unpack_opargsneeds this context to avoid interpreting inlineCACHEentries asEXTENDED_ARGs (which happens very easily on big-endian platforms).