Enable CI on Python 3.10#11297
Conversation
.github/workflows/test.yml
Outdated
| if: ${{ matrix.python == '3.10' }} | ||
| run: pip install --upgrade virtualenv==20.4.7 |
There was a problem hiding this comment.
I think it might be better to just use virtualenv 20 always instead of just on python 3.10. #10855 seems to have added support for using virtualenv 20, so I think that PR just forgot to update the CI to use virtualenv 20.
|
You may need to fix the build by fixing mypyc imports first |
|
We could probably merge #11017 first |
Done! |
|
Hooray! |
|
Can we merge master for #11306 |
| """ | ||
|
|
||
| from distutils.core import setup | ||
| from setuptools import setup |
There was a problem hiding this comment.
I think the usage of distutils that is causing a DeprecationWarning is in the setup.py mypyc generates to build C extensions:
Lines 21 to 28 in 8cba3bc
I'm not really sure what this file's for but I don't think this is what's causing the CI failure.
There was a problem hiding this comment.
yeah, I'm looking at these. However I just wondering whether should I modify the test-data/packages/typedpkg-stubs/setup.py
There was a problem hiding this comment.
That's a sample package used for unit tests. We should probably update it too, but it should only affect a few unit tests.
|
Passes all tests now |
TH3CHARLie
left a comment
There was a problem hiding this comment.
great job on making Python 3.10 working in CI
Description
Closes #11294
Test Plan
Check the tests still failed.