Do not auto-infer TypeGuard return type for lambda, refs #9927#11417
Merged
hauntsaninja merged 1 commit intopython:masterfrom Oct 31, 2021
sobolevn:issue-9927
Merged
Do not auto-infer TypeGuard return type for lambda, refs #9927#11417hauntsaninja merged 1 commit intopython:masterfrom sobolevn:issue-9927
TypeGuard return type for lambda, refs #9927#11417hauntsaninja merged 1 commit intopython:masterfrom
sobolevn:issue-9927
Conversation
Member
Author
|
One might notice that it still reveals |
Collaborator
|
Thank you!! |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's what was happening in this example:
Mypy uses special logic in
infer_lambda_type_using_contextto inferlambdatype args and return type. Basically, it just returns the current callable context type. Which isCallable[[T], TypeGuard[R]]in our case.But, now I've limited this function to ignore contexts with
TypeGuard. Because I believe thatTypeGuardmust always be explicit.After this change Mypy works correctly:
Because we don't allow
boolreturn type whereTypeGuardis expected after #11314The test from @gvanrossum that used to be skipped now passes 🎉
Closes #9927