Infra: CSS: Show borders around merged cells#4817
Merged
encukou merged 1 commit intopython:mainfrom Feb 12, 2026
Merged
Conversation
Showing all borders around cells fixes the presentation for "merged" cells (rowspan/colspan, like in PEP 393). `<table>` elements already have `border-collapse` set, which means that adjacent borders are merged. It's not necessary to set inside borders only on cells & outside ones on the table.
hugovk
approved these changes
Feb 12, 2026
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Fixed table for comparison: https://pep-previews--4817.org.readthedocs.build/pep-0393/#performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing all borders around cells fixes the presentation for "merged" cells (rowspan/colspan), like in PEP 393 (and a table I'm preparing now):
<table>s already haveborder-collapseset, which means that adjacent borders are merged.It's not necessary to set inside borders only on cells & outside ones on the table.
📚 Documentation preview 📚: https://pep-previews--4817.org.readthedocs.build/